* Update ClientSecret in the example to not call itself a GUID
If manually crafting or verifying a Service Principal credential JSON object, it is helpful to know that only the `clientId` is formatted as a GUID, and the `clientSecret` is just an alphanumeric string.
* Update README.md
Co-authored-by: Balaga Gayatri <balaga-gayatri@github.com>
* Add critical information if manually creating SP Credential object
If you must manually create the credential JSON (for instance, the Service Principal was created and assigned but the output credential was not saved), finding the `clientId`, `clientSecret`, `subscriptionId` and `tenantId` in azure is possible, but the `resourceManagerEndpointUrl` is also required by this Action and was much harder to track down.
By explaining it is possible and including the value for the public azure cloud (the default use case) it will help others be able to use this Action with existing Service Principal's as well.
* Update README.md
Co-authored-by: Balaga Gayatri <balaga-gayatri@github.com>
Updated Readme.md with App Registration instructions. Without the instructions new user will be lost with the instructions provided as none of the menus/options appear.
The clientSecret is not a GUID, and this being labelled as such caused confusion when I tried to manually add a client secret and was met with a SecretId which was a GUID and a SecretValue which was not a GUID. Using the SecretId GUID from the Azure UI would not work.
Also, resourceManagerEndpointUrl was required but not shown in any examples.
Finally, the value for it was hard to determine, as using several azure cli commands did not display it.
Co-authored-by: Kanika Pasrija <58769601+kanika1894@users.noreply.github.com>
Updates the Azure Gov cloud example to have valid YAML syntax and to increase consistency between examples.
Co-authored-by: Kanika Pasrija <58769601+kanika1894@users.noreply.github.com>
* Updating instructions to include Azure Stack Hub
Added sample work flow for ASH and service principle instructions
* Updating based on PR feedback
- Added a description to environment parameter
- Updated instructions to say "required only for ash" for service principle instructions
Co-authored-by: Amruta Kawade <65217380+AmrutaKawade@users.noreply.github.com>
* Add explanation of az ad sp create-for-rbac
Fulfills an internal Microsoft request to explain what the command is doing.
Also cleans up the readmd a little and add a note about forking a sample repository when applicable.
* Add note on managing service principals
* Update secrets link
