added review comments

This commit is contained in:
Akshaya M
2020-03-19 19:27:30 +05:30
parent 7e72509c6b
commit a2be320a3e
12 changed files with 472 additions and 110 deletions

View File

@@ -44,13 +44,15 @@ function main() {
if (!servicePrincipalId || !servicePrincipalKey || !tenantId || !subscriptionId) {
throw new Error("Not all values are present in the creds object. Ensure clientId, clientSecret, tenantId and subscriptionId are supplied.");
}
// Attempting Az cli login
yield executeAzCliCommand(`login --service-principal -u "${servicePrincipalId}" -p "${servicePrincipalKey}" --tenant "${tenantId}"`);
yield executeAzCliCommand(`account set --subscription "${subscriptionId}"`);
if (enablePSSession) {
// Attempting Az PS login
console.log(`Running Azure PS Login`);
const spnlogin = new ServicePrincipalLogin_1.ServicePrincipalLogin(servicePrincipalId, servicePrincipalKey, tenantId, subscriptionId);
spnlogin.initialize();
spnlogin.login();
yield spnlogin.initialize();
yield spnlogin.login();
}
console.log("Login successful.");
}