From cfcf0831f3193369cf57dafe7061ea13c9608f02 Mon Sep 17 00:00:00 2001 From: AStancu Date: Tue, 6 Sep 2022 21:53:37 +0000 Subject: [PATCH] Added execution context error This will make a failed health check more visible in the UI without disrupting the execution of the program. --- src/Runner.Worker/ContainerOperationProvider.cs | 3 ++- src/Test/L0/Worker/ContainerOperationProviderL0.cs | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Runner.Worker/ContainerOperationProvider.cs b/src/Runner.Worker/ContainerOperationProvider.cs index 61b40b7a7..67f19f95d 100644 --- a/src/Runner.Worker/ContainerOperationProvider.cs +++ b/src/Runner.Worker/ContainerOperationProvider.cs @@ -429,8 +429,9 @@ namespace GitHub.Runner.Worker } else { - executionContext.Output($"##[group] Container {container.ContainerImage} failed healthchecks, printing logs:"); + executionContext.Output($"##[group]Container {container.ContainerImage} failed healthchecks, printing logs:"); await _dockerManager.DockerLogs(context: executionContext, containerId: container.ContainerId); + executionContext.Error($"Failed to initialize container {container.ContainerImage}"); executionContext.Output("##[endgroup]"); } } diff --git a/src/Test/L0/Worker/ContainerOperationProviderL0.cs b/src/Test/L0/Worker/ContainerOperationProviderL0.cs index 56a6f5e54..a1c3b70cc 100644 --- a/src/Test/L0/Worker/ContainerOperationProviderL0.cs +++ b/src/Test/L0/Worker/ContainerOperationProviderL0.cs @@ -64,7 +64,7 @@ namespace GitHub.Runner.Common.Tests.Worker //Assert _ec.Verify(dm => dm.Write(It.IsAny(), It.IsAny()), Times.Exactly(2)); - _ec.Verify(dm => dm.Write(null, $"##[group] Container {containerInfo.ContainerImage} failed healthchecks, printing logs:"), Times.AtLeastOnce()); + _ec.Verify(dm => dm.Write(null, $"##[group]Container {containerInfo.ContainerImage} failed healthchecks, printing logs:"), Times.AtLeastOnce()); _ec.Verify(dm => dm.Write(null, "##[endgroup]"), Times.AtLeastOnce()); }